Connecting itinerary manager to settings#115
Open
erik-rosenstrom wants to merge 1 commit intoetr-school-closure-draft-reactivefrom
Open
Connecting itinerary manager to settings#115erik-rosenstrom wants to merge 1 commit intoetr-school-closure-draft-reactivefrom
erik-rosenstrom wants to merge 1 commit intoetr-school-closure-draft-reactivefrom
Conversation
confunguido
requested changes
May 7, 2026
Collaborator
confunguido
left a comment
confunguido
left a comment
There was a problem hiding this comment.
A few comments but also think this needs to wait until we modify the dominant itinerary approach.
|
|
||
| } | ||
|
|
||
| pub fn init(context: &mut Context) -> Result<(), ModelError> { |
Collaborator
There was a problem hiding this comment.
These itineraries look like a test. It's okay to leave them as part of the tests if we aren't ready to define some itinerary modifiers them right now.
| self.get_itinerary_modifiers(person_id).into_iter().max() | ||
| } | ||
|
|
||
| fn get_dominant_itinerary_modifier_ratios(&self, person_id: PersonId) -> ItineraryRatios { |
Collaborator
There was a problem hiding this comment.
This looks like it will change when you incorporate a different approach for the itinerary modifiers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR connects the registered itinerary modifiers to settings and the infection propagation loop. A context extension method is implemented for the itinerary manager that returns the itinerary ratios of a person's dominate itinerary modifier. If there are no itinerary modifiers registered the person default itinerary ratios are returned. This implementation does not modify persons itinerary ratios person properties.